[cxx-interop] Do not import arithmetic operators with rvalue reference parameters #80763
+50
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e parameters Currently those operators are imported with a `consuming:` label, which isn't valid in Swift. We could just remove the label from these parameters, but that introduces a source breakage due to name lookup ambiguity. So, to avoid ambiguity, let's not import such operators into Swift. rdar://149020099
egorzhdan
requested review from
zoecarver,
Xazax-hun,
j-hui,
fahadnayyar,
susmonteiro,
hnrklssn,
beccadax and
ian-twilightcoder
as code owners
j-hui
approved these changes
Apr 11, 2025
There was a problem hiding this comment.
Looks good to me!
Just to make sure I understand this correctly: it's not source-breaking to simply remove these because an operator with a consuming: label doesn't really make any sense in the first place. Is that right?
Not for this patch, but I'm also wondering if you have thoughts on how we might support these operators in the future?
Xazax-hun
approved these changes
Apr 11, 2025
|
I guess in the future we can theoretically import these operators iff there is no overload with lvalue reference parameters. But I'm not sure if it's common to have an rvalue overload but no lvalue overload for these operators. |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently those operators are imported with a
consuming:label, which isn't valid in Swift.We could just remove the label from these parameters, but that introduces a source breakage due to name lookup ambiguity.
So, to avoid ambiguity, let's not import such operators into Swift.
rdar://149020099