Revert #79707 #80767
Merged
Revert #79707 #80767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meg-gupta
requested review from
a team,
Xazax-hun,
eeckstein,
egorzhdan,
fahadnayyar,
hnrklssn,
j-hui,
rjmccall,
susmonteiro and
zoecarver
as code owners
meg-gupta
changed the title
Contributor
Author
|
@swift-ci test |
Merged
Contributor
Author
|
@swift-ci test linux platform |
1 similar comment
Member
|
@swift-ci test linux platform |
meg-gupta
added a commit
to meg-gupta/swift
that referenced
this pull request
Apr 19, 2025
Revert "Merge pull request swiftlang#80767 from meg-gupta/reverttransparent" This reverts commit 198a802, reversing changes made to 8eb43af.
Merged
meg-gupta
added a commit
to meg-gupta/swift
that referenced
this pull request
Apr 21, 2025
Revert "Merge pull request swiftlang#80767 from meg-gupta/reverttransparent" This reverts commit 198a802, reversing changes made to 8eb43af.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#79707 made some integer operations transparent enabling them to be inlined during MandatoryInlining. With this OSLogOptimization needs to analyze the inlined function bodies of these integer operations since it runs after MandatoryInlining.
In certain configurations, stdlib's FixedWidthInteger.bitwidth and others are not inlined and OSLogOptimization misses to determine these calls as constants. rdar://148256435 and rdar://148302110 track this and can be resolved by #80712 [not merged] .
However I am reverting #79707 here because rdar://148244242 does not have a resolution at the moment.