Skip to content

Revert #79707 #80767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Revert #79707 #80767

wants to merge 1 commit into from
+18 −44

Conversation

meg-gupta
Copy link
Contributor

@meg-gupta meg-gupta commented Apr 11, 2025 •
edited
Loading

#79707 made some integer operations transparent enabling them to be inlined during MandatoryInlining. With this OSLogOptimization needs to analyze the inlined function bodies of these integer operations since it runs after MandatoryInlining.

In certain configurations, stdlib's FixedWidthInteger.bitwidth and others are not inlined and OSLogOptimization misses to determine these calls as constants. rdar://148256435 and rdar://148302110 track this and can be resolved by #80712 [not merged] .

However I am reverting #79707 here because rdar://148244242 does not have a resolution at the moment.

@meg-gupta
Revert "Merge pull request swiftlang#79707 from DougGregor/transparen…
f462bc5 
…t-integer-conversions"

This reverts commit 9c2c4ea, reversing
changes made to 829e03c.
@meg-gupta meg-gupta requested a review from DougGregor April 11, 2025 17:45
@meg-gupta meg-gupta changed the title Revert "Merge pull request #79707 from DougGregor/transparent-integer… Revert #79707 Apr 11, 2025
@meg-gupta
Copy link
Contributor Author

@swift-ci test

@meg-gupta meg-gupta mentioned this pull request Apr 11, 2025
Merged
@meg-gupta
Copy link
Contributor Author

@swift-ci test linux platform

1 similar comment
@shahmishal
Copy link
Member

@swift-ci test linux platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eeckstein eeckstein Awaiting requested review from eeckstein eeckstein is a code owner

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

@egorzhdan egorzhdan Awaiting requested review from egorzhdan egorzhdan is a code owner

@Xazax-hun Xazax-hun Awaiting requested review from Xazax-hun Xazax-hun is a code owner

@j-hui j-hui Awaiting requested review from j-hui j-hui is a code owner

@fahadnayyar fahadnayyar Awaiting requested review from fahadnayyar fahadnayyar is a code owner

@susmonteiro susmonteiro Awaiting requested review from susmonteiro susmonteiro is a code owner

@hnrklssn hnrklssn Awaiting requested review from hnrklssn hnrklssn is a code owner

@rjmccall rjmccall Awaiting requested review from rjmccall rjmccall is a code owner

@DougGregor DougGregor Awaiting requested review from DougGregor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meg-gupta @shahmishal