[Concurrency] Remove -executor-factory option and replace with magic type. #80795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…type. We decided that using a magic typealias to set the executor factory was better than using a compiler option. Remove the `-executor-factory` option, and replace by looking up the `DefaultExecutorFactory` type, first in the main module, and then if that fails in Concurrency. rdar://149058236
|
Explanation: In conversations with Holly and Konrad, we decided that a magic typealias was a better way to express the default executor factory, and also avoids having to add options to SwiftPM, swift-build and the driver. |
|
@swift-ci Please test |
al45tair
added
🍒 release cherry pick
ktoso
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided that using a magic typealias to set the executor factory was better than using a compiler option. Remove the
-executor-factoryoption, and replace by looking up theDefaultExecutorFactorytype, first in the main module, and then if that fails in Concurrency.rdar://149058236