[Caching] Reduce the number of cas ID passed on frontend commandline #81264
+101
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachemeifyoucan
requested review from
hborla,
slavapestov,
xedin,
tshortli,
zoecarver,
egorzhdan,
beccadax,
ian-twilightcoder,
Xazax-hun,
j-hui,
fahadnayyar,
susmonteiro and
DougGregor
as code owners
|
please test with following PR: @swift-ci please smoke test |
Xazax-hun
reviewed
May 4, 2025
| ArrayRef<std::string> IncludeTrees, | ||
| ArrayRef<std::string> IncludeTreeFileList) { | ||
| assert(!FSRoots.empty() || !IncludeTrees.empty() || | ||
| const std::string &IncludeTree, |
There was a problem hiding this comment.
Shouldn't we prefer StringRef here?
There was a problem hiding this comment.
The input is always a std::string from FrontendOptions. I don't see StringRef is necessary and it adds overhead if not inlined.
|
ping |
benlangmuir
approved these changes
May 12, 2025
Using IncludeTree::FileList to concat the include tree file systems that are passed on the command-line. This significantly reduce the command-line size, and also makes the cache key computation a lot faster. rdar://148752988
cachemeifyoucan
force-pushed
the
eng/PR-148752988
branch
from
f0ee535 to
ec6cdfa
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test linux platform |
|
@swift-ci please smoke test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using IncludeTree::FileList to concat the include tree file systems that are passed on the command-line. This significantly reduce the command-line size, and also makes the cache key computation a lot faster.
rdar://148752988