Serialization: Lazily deserialize OpaqueTypeDecl's underlying substitutions [6.3] #85684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utions We need to serialize the underlying type substitution map for an inlinable function. However, there is no reason to deserialize it eagerly, since doing so can lead to cycles. It is better for correctness and performance to only deserialize it when needed. Technically this fixes a regression from swiftlang#84299, but the actual problem was there all along, it was just exposed by my change on a specific project. Fixes rdar://163301203.
Contributor
Author
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: We need to serialize the underlying type substitution map for an inlinable function. However, there is no reason to deserialize it eagerly, since doing so can lead to cycles. It is better for correctness and performance to only deserialize it when needed.
Scope of the issue: Request cycles when multiple overloads of the same symbol have opaque result types, one is inlinable, and it depends on the other.
Origination: Technically this fixes a regression from AST: Allow non-canonical opaque archetypes #84299, but the actual problem was there all along, it was just exposed by my change on a specific project.
Radar: Fixes rdar://163301203.
Reviewed by: TBD
Risk: Medium, perhaps, because this is a bigger change, but it's early in the release cycle.