[6.3 🍒][CSOptimizer] Also favor existential metatype candidates in paramType isAny fast path #85686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overload resolution picks wrong initializer for some metatype arguments swiftlang#85020
xedin
approved these changes
Nov 24, 2025
Contributor
xedin
left a comment
xedin
left a comment
There was a problem hiding this comment.
Thank you again for the report and the fix!
Author
Cheers! Thanks for the feedback and review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
Resolves a regression in overload resolution with metatype candidates.
Scope:
Besides resolving the regression, the fix adds an additional fast path for metatypes, so it is not expected to negatively impact performance.
Issues:
Resolves: Overload resolution picks wrong initializer for some metatype arguments #85020
Resolves: rdar://163074598
Original PRs:
[CSOptimizer] Also favor existential metatype candidates in paramType isAny fast path #85652
Risk:
Low. The change only tweaks overload scoring when the parameter is Any/Any.Type, returning to the same behavior as is in current/previous releases.
Testing:
Adds a test case to catch this specific behavior. I also built a custom toolchain with this fix and verified that the issue is resolved in the original project in which it was discovered.
Reviewers:
@xedin