SILCombine: fix propagation of concrete existentials in enums #85691
+33
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This peephole optimization didn't consider that an alloc_stack of an enum can be overridden by another value. The fix is to remove this peephole optimization at all because it is already covered by `optimizeEnum` in alloc_stack simplification. Fixes a miscompile swiftlang#85687 rdar://165374568
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
|
@swift-ci apple silicon benchmark |
Contributor
Author
|
@swift-ci smoke test macos |
Contributor
|
i assume this is intended to fix #85689, and not the issue currently in the description/commit message? |
Contributor
Author
Yes, thanks! |
Contributor
Author
|
@swift-ci smoke test windows |
1 similar comment
Contributor
Author
|
@swift-ci smoke test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This peephole optimization didn't consider that an alloc_stack of an enum can be overridden by another value. The fix is to remove this peephole optimization at all because it is already covered by
optimizeEnumin alloc_stack simplification.Fixes a miscompile
#85689
rdar://165374568