[cxx-interop] Do not drop CV qualifiers during printing template names #85694
+96
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xazax-hun
requested review from
beccadax,
egorzhdan,
hnrklssn,
ian-twilightcoder,
j-hui and
susmonteiro
as code owners
egorzhdan
reviewed
Nov 25, 2025
|
|
||
| using MagicWrapperFrt = MagicWrapper<Foo *>; | ||
| using MagicWrapperConstFrt = MagicWrapper<const Foo *>; | ||
| using MagicWrapperVolatileFrt = MagicWrapper<volatile Foo *>; |
Contributor
There was a problem hiding this comment.
Could you please also add a definition that refers to the FRT by reference? e.g. MagicWrapper<const Foo &>
Dropping qualifiers can result in collisions that can trigger compiler crashes or suprious errors. This PR attempts to make sure we always handle the qualifiers when a qualified type is present in the Clang API. The handling of pointers is somewhat special as foreign reference types has custom printing logic. rdar://164917816
Xazax-hun
force-pushed
the
const-frts-collision
branch
from
cd6b00b to
cd4e3cc
Compare
Contributor
Author
|
@swift-ci please smoke test |
j-hui
approved these changes
Nov 25, 2025
Contributor
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropping qualifiers can result in collisions that can trigger compiler crashes or suprious errors. This PR attempts to make sure we always handle the qualifiers when a qualified type is present in the Clang API. The handling of pointers is somewhat special as foreign reference types has custom printing logic.
rdar://164917816