Sema: SuppressedAssociatedTypesWithDefaults #85704
Draft
+1,055
−118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's about to be a second version that I'd like to test in parallel with the old version.
This is similar to SuppressedAssociatedTypes, but infers default requirements when primary associated types of protocols are suppressed. This defaulting for the primary associated types happens in extensions of the protocol, along with generic parameters, whenever a source-written requirement states a conformance requirement for the protocol. Thus, the current scheme for this defaulting is a simplistic, driven by source-written requirements, rather than facts that are inferred while building generic signatures. Defaults are not expanded for infinitely many associated types. Other changes include... Sema: adjust protocol extension signature hack With SuppressedAssociatedTypesWithDefaults, we can have associated types that are missing invertible conformance requirements, so we need to try re-building the signature for the extension of the protocol. Otherwise, we won't infer the new default(s) for those associated types. This previous hack was only trying to shortcut the rebuilding if it saw Self is lacking a conformance requirement. Now it'll check if any inverses were written in source for that protocol.
kavon
force-pushed
the
suppressed-assoc-types-with-defaults
branch
from
7a739ba to
c486f40
Compare
Member
Author
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.