[cxx-interop] Fix crash when virtual methods take move-only types #85711
+47
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We build forwarding methods to call the virtual methods. The forwarding methods tried to copy move-only types which resulted in a compiler crash. Now we try to detect this scenario and insert the required cast to make sure we get a move instead. rdar://162195228
Xazax-hun
requested review from
beccadax,
egorzhdan,
hnrklssn,
ian-twilightcoder,
j-hui and
susmonteiro
as code owners
Contributor
Author
|
@swift-ci please smoke test |
egorzhdan
approved these changes
Nov 26, 2025
susmonteiro
approved these changes
Nov 26, 2025
j-hui
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We build forwarding methods to call the virtual methods. The forwarding methods tried to copy move-only types which resulted in a compiler crash. Now we try to detect this scenario and insert the required cast to make sure we get a move instead.
rdar://162195228