Prevent invalid attributes from being added to DeclAttributeList #86590
+8
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified DeclAttributeList::add() to validate whether the attribute can appear on the given declaration before adding it to the list. rdar://164975727
Contributor
Author
|
@swift-ci please test |
sepy97
force-pushed
the
preconcurrency_textualinterface
branch
from
cbe7200 to
bbd71a4
Compare
Contributor
Author
|
@swift-ci please test |
jamieQ
reviewed
Jan 16, 2026
| Attr->Next = DeclAttrs; | ||
| DeclAttrs = Attr; | ||
| void add(DeclAttribute *Attr, const Decl *D = nullptr) { | ||
| if (D && !Attr->canAppearOnDecl(D)) { |
Contributor
There was a problem hiding this comment.
out of curiosity – do you have an example of something this will now handle that previously would have been permitted?
Contributor
Author
|
Resolves issue #85564 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified DeclAttributeList::add() to validate whether the attribute can appear on the given declaration before adding it to the list.