[6.3][ASTMangler] Restore stripConcurrency behavior for `@preconcurrency…
#86640
+59
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` declarations This is a follow-up to swiftlang#86557 When mangling a `@preconcurrency` declaration, `dropGlobalActor` is set to `true`, and the original condition behind that used to remove isolation from function types regardless of whether the function type was actually global-actor isolated or not. We need to maintain this behavior for mangling or risk breaking ABI for the existing declarations that had isolation like `@isolated(any)`. (cherry picked from commit 6487b43)
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…` declarations
Explanation:
This is a follow-up to [Concurrency] Fix
stripConcurrencyto strip only global actor isola… #86557When mangling a
@preconcurrencydeclaration,dropGlobalActoris set totrue, and the original condition behind that used to remove isolation from function types regardless of whether the function type was actually global-actor isolated or not. We need to maintain this behavior for mangling or risk breaking ABI for the existing declarations that had isolation like@isolated(any).Resolves: rdar://167712422
Main Branch PR: [ASTMangler] Restore
stripConcurrencybehavior for `@preconcurrency… #86625Risk: Low. Restores mangling behavior of
@preconcurrencydeclarations.Reviewed By: TBD
Testing: Added new test-cases to the suite.
(cherry picked from commit 6487b43)