[cxx-interop] Do not crash when an operator returns an internal type as auto
#86643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as `auto` If an overloaded operator returns `auto`, and the implementation of it returns an instance of a type declared within the operator, Swift was crashing when trying to import the internal type. Instead of crashing, let's not import those overloads. rdar://159271202 / resolves swiftlang#83942
Contributor
Author
|
@swift-ci please test |
egorzhdan
requested review from
Xazax-hun,
beccadax,
hnrklssn,
ian-twilightcoder,
j-hui and
susmonteiro
as code owners
Contributor
Author
|
@swift-ci please test Linux |
Xazax-hun
reviewed
Jan 19, 2026
|
|
||
| auto decl = dyn_cast<clang::NamedDecl>(dc); | ||
| if (!decl) | ||
| if (!decl || !decl->getDeclName().isIdentifier()) |
Contributor
There was a problem hiding this comment.
Would this also prevent us importing types from unnamed structs like:
struct S {
struct {
struct Inner {
int a, b;
} c;
auto f() {
return Inner{1, 2};
}
} d;
};
?
And if it would, is that intentional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an overloaded operator returns
auto, and the implementation of it returns an instance of a type declared within the operator, Swift was crashing when trying to import the internal type. Instead of crashing, let's not import those overloads.rdar://159271202 / resolves #83942