Game Demo Port #611
Open
Game Demo Port #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #611 +/- ##
==========================================
- Coverage 50.98% 50.26% -0.72%
==========================================
Files 378 391 +13
Lines 32517 33136 +619
==========================================
+ Hits 16578 16657 +79
- Misses 15939 16479 +540 ☔ View full report in Codecov by Sentry. |
Comment on lines
+32
to
+50
| pub fn ui_server_router(port: u16) -> Router { | ||
| Router::new() | ||
| .route("/index.html", get(index_html)) | ||
| .route("/lib/game.min.js", get(game_min_js)) | ||
| .route("/lib/game.min.js.map", get(game_min_js_map)) | ||
| .route("/lib/swim-core.min.js", get(swim_core_min_js)) | ||
| .route("/lib/swim-core.min.js.map", get(swim_core_min_js_map)) | ||
| .route("/lib/swim-host.min.js", get(swim_host_min_js)) | ||
| .route("/lib/swim-host.min.js.map", get(swim_host_min_js_map)) | ||
| .route("/lib/swim-ui.min.js", get(swim_ui_min_js)) | ||
| .route("/lib/swim-ui.min.js.map", get(swim_ui_min_js_map)) | ||
| .route("/lib/swim-ux.min.js", get(swim_ux_min_js)) | ||
| .route("/lib/swim-ux.min.js.map", get(swim_ux_min_js_map)) | ||
| .route("/lib/swim-vis.min.js", get(swim_vis_min_js)) | ||
| .route("/lib/swim-vis.min.js.map", get(swim_vis_min_js_map)) | ||
| .route("/assets/favicon.ico", get(favicon)) | ||
| .route("/assets/swim-logo.png", get(swim_logo)) | ||
| .with_state(UiConfig { port }) | ||
| } |
There was a problem hiding this comment.
I realize that this is copied from the example app I did but it's definitely hacky. We shoul probably make somethiung more general if we're going to have a lot of these.
SirCipher
reviewed
Apr 25, 2024
Comment on lines
+154
to
+155
| // pub total_duration: u64, | ||
| // pub last_online: u64, |
Comment on lines
+178
to
+179
| // self.total_duration += match_summary.duration; | ||
| // self.last_online = match_summary.end_time; |
| } | ||
|
|
||
| fn configure_logging() -> Result<(), Box<dyn std::error::Error + Send + Sync>> { | ||
| let filter = example_filter()? |
There was a problem hiding this comment.
You should just be able to depend on the example_util crate rather than copying this here. You could maybe add a new function there that accepts a slice of additional directives to add
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very rough first draft of the game demo port - needs few iterations of tidying before merging.