[DS 4002] Improve ability for users to configure GenAI model for RAG #1593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results67 tests 67 ✅ 33s ⏱️ Results for commit 97bccfb. ♻️ This comment has been updated with latest results. |
erikspears
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for configuring the AZURE_API_VERSION via the .env file and settings.py, replacing the previously hardcoded value in openai.py.
Additionally, it ensures that the system can switch between Azure OpenAI and OpenAI clients purely through environment variables, without requiring code modifications. This helps support more flexible deployment and testing of various model versions and providers.
Testing and Validation
AZURE_API_VERSIONto.envand verified that the value is read viasettings.py.openai.pyto usesettings.AZURE_API_VERSIONdynamically.OPENAI_API_KEYandSWIRL_RAG_MODEL=gpt-4oto confirm OpenAI client works as expected.Type of Change
[ x ] Bug fix or other non-breaking change that addresses an issue
[ x ] New Feature / Enhancement (non-breaking change that add or improves functionality)