-
Notifications
You must be signed in to change notification settings - Fork 5
fix(editor): added option for consuming application to add samples in… #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(editor): added option for consuming application to add samples in… #38
Conversation
1a58c5a
to
9d2e2a3
Compare
…app code base, Readme pending
9d2e2a3
to
07a13b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this. Looks cool!
As always 😆, I do have some suggestions to make this feature more generic.
src/main/content/jcr_root/apps/jcr-hopper/script-builder/scripts/.content.xml
Show resolved
Hide resolved
src/main/content/jcr_root/apps/jcr-hopper/script-builder/scripts/.content.xml
Outdated
Show resolved
Hide resolved
src/main/java/com/swisscom/aem/tools/jcrhopper/osgi/SampleContributor.java
Show resolved
Hide resolved
Hi @sabberworm , The issue that occurred with rebase is resolved now. Could you please review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I do have some reservations about the README becoming too complex (and too specific) and added some suggestions to simplify. But we can also tackle this some other time.
No description provided.