Skip to content

fix(editor): added option for consuming application to add samples in… #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

akaash2512
Copy link
Collaborator

@akaash2512 akaash2512 commented May 9, 2025

No description provided.

@akaash2512 akaash2512 self-assigned this May 9, 2025
@akaash2512 akaash2512 force-pushed the Feature/29-add-external-path-for-sample-scripts branch from 1a58c5a to 9d2e2a3 Compare May 9, 2025 14:44
@akaash2512 akaash2512 force-pushed the Feature/29-add-external-path-for-sample-scripts branch from 9d2e2a3 to 07a13b1 Compare May 9, 2025 14:45
Copy link
Collaborator

@sabberworm sabberworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this. Looks cool!
As always 😆, I do have some suggestions to make this feature more generic.

@akaash2512 akaash2512 requested a review from sabberworm May 20, 2025 14:11
@akaash2512
Copy link
Collaborator Author

Hi @sabberworm , The issue that occurred with rebase is resolved now. Could you please review?

Copy link
Collaborator

@sabberworm sabberworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I do have some reservations about the README becoming too complex (and too specific) and added some suggestions to simplify. But we can also tackle this some other time.

@akaash2512 akaash2512 merged commit a1726ea into swisscom:main May 22, 2025
2 checks passed
@akaash2512 akaash2512 deleted the Feature/29-add-external-path-for-sample-scripts branch May 22, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants