Skip to content

chore(primeng): update to Angular 19 #5185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: release/v8
Choose a base branch
from
Open

Conversation

alizedebray
Copy link
Contributor

📄 Description

This PR is about updating the PrimeNg styles to fit the new structure offers by PrimeNg 19, therefore allowing an upgrade to Angular 19.


📝 Checklist

  • ✅ My code follows the style guidelines of this project
  • 🛠️ I have performed a self-review of my own code
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings or errors
  • 🧪 I have added tests that prove my fix is effective or that my feature works
  • ✔️ New and existing unit tests pass locally with my changes

@alizedebray alizedebray requested a review from a team as a code owner April 2, 2025 15:36
Copy link

changeset-bot bot commented Apr 2, 2025

🦋 Changeset detected

Latest commit: a1df7ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
@swisspost/design-system-styles-primeng Major
@swisspost/design-system-styles Major
@swisspost/design-system-tokens Major
@swisspost/design-system-components Major
@swisspost/design-system-components-angular Major
@swisspost/design-system-components-react Major
@swisspost/design-system-intranet-header Major
@swisspost/design-system-icons Major
@swisspost/design-system-migrations Major
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-demo Patch
@swisspost/design-system-documentation Patch
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header-workspace Patch
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-styles-primeng-workspace Patch
@swisspost/design-system-intranet-header-showcase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Apr 2, 2025

Related Previews

Copy link

sonarqubecloud bot commented Apr 8, 2025

@alizedebray alizedebray requested a review from gfellerph April 15, 2025 07:10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this file being added here?

@@ -1,3 +1,2 @@
@use 'primeng-theme';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally, I'm getting an error here that this stylesheet can't be found.

Copy link
Member

@gfellerph gfellerph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alizedebray can you write another ticket with what needs to be done in order to update to Angular 19 from v8?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants