Re-implement esbonio.sphinx.configOverrides
#870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcarney
force-pushed
the
config-override
branch
from
0504fd4
to
c2449de
Compare
Nothing against furo, but not depending on it for test cases is one less dependency to migrate when a major version of Sphinx rolls around. Plus overriding the theme set in `conf.py` is a nice way to exercise the `configOverrides` option
alcarney
force-pushed
the
config-override
branch
from
c2449de
to
1ed42a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The brings back the
sphinx.configOverridesoption from the0.xversion ofesbonio, offering a convenient way to override parts of a project'sconf.pyfile{ "esbonio": { "sphinx": { "pythonCommand": ["/path/to/venv/bin/python"], "buildCommand": ["sphinx-build", "-M", "dirhtml", "docs/", "docs/_build"], "configOverrides": { "html_theme": "alabaster", "html_theme_options": {}, } } } }Closes #785