code: Use vscode.env.asExternalUri to generate preview uris
#905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to running the preview uri from the server through `vscode.env.asExternalUri` we need to make sure that the CSP for the embedded iframe is given the correct origin.
alcarney
force-pushed
the
fix-codespaces
branch
from
971fb91 to
e2cee7e
Compare
The injected `webview.js` script now assumes that the `ws` query parameter contains the entire URI to use when creating the websocket connection
alcarney
force-pushed
the
fix-codespaces
branch
from
85a125f to
eb59a4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks it fixes #896
wsquery parameter e.g.?ws=ws://localhost:1234vscode.env.asExternalUrion both thehttp://andws://URIs which triggers the relevant ports to be forwarded when run in CodeSpaces