init.el: Prevent unnecessarily calling server-start in some cases #17015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, if Spacemacs is invoked in batch mode.
Let the normal startup sequence take care of it instead. Otherwise, in certain Emacs versions, an error during after-init-hook can cause the daemon to hang indefinitely without reporting the error properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namely, don't call
(server-start), even whendotspacemacs-enable-serveris non-nil, in the following cases:emacs --batch -u ""(normally --batch disables reading the user'sinit file such as Spacemacs, but it is a reasonable use-case to
run a batch Spacemacs)
emacs --daemonNormally it is harmless to run
(server-start)explicitly when Emacsis started as a daemon, but on some versions of Emacs this can
interfere with error handling at startup, and in any case it is
redundant and should be left to the normal Emacs command-line
handling.