Support orderless annotation and kwd matchers. #17052
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orderless has a few new matchers that are quite useful. The kwd matcher provides a lot of different ones based on different modes, and the annotation matcher with `&` allows you to match against all marginalia annotations. To enable this we need to change the component separators back to the default (which is a space not preceded by a backslash). This could be left as a configuration option, but I figured the nicest solution was to use the default. People can override if they prefer the other behaviour.
(It might be possible to replace the advice by defining a separate completion style for in-buffer completion, see orderless-define-completion-style and the discussion in minad/consult#1131.)
|
Thanks, these matchers are indeed useful. I would prefer to keep the (As mentioned in the commit message, it might be possible to replace the advice by defining a separate completion |
|
Ahhhh! That's what it's for! For company. Seems good. I'll try and test this tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Orderless has a few new matchers that are quite useful. The kwd matcher provides a lot of different ones based on different modes, and the annotation matcher with
&allows you to match against all marginalia annotations.To enable this we need to change the component separators back to the default (which is a space not preceded by a backslash).
This could be left as a configuration option, but I figured the nicest solution was to use the default. People can override if they prefer the other behaviour.
It seems to have supported this for a bit over a year now.
Reference to orderless-kwd: https://github.com/oantolin/orderless/blob/master/orderless-kwd.el
and the base annotation matcher with
&: https://github.com/oantolin/orderless?tab=readme-ov-file#style-dispatchers (orderless-annotation)