[core] Phase out the spacemacs|dotspacemacs-backward-compatibility #17062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix #16884 partially. |
bcc32
requested changes
Jul 19, 2025
| @@ -26,7 +26,8 @@ | |||
| (defmacro spacemacs|dotspacemacs-backward-compatibility (variable default) | |||
| "Return `if' sexp for backward compatibility with old dotspacemacs | |||
| values." | |||
| `(if (boundp ',variable) ,variable ',default)) | |||
| (warn "The `dotspacemacs-backward-compatibility' will be removed after 2025. | |||
| Please reinstall the package which relies on this macro.")) | |||
There was a problem hiding this comment.
I think directly replacing the real macro definition will break any interpreted code which relies on the macro, right? Furthermore, this warning won't get triggered by any compiled code, which already expanded the macro.
sunlin7
force-pushed
the
rework-compatible
branch
from
473b40e to
2eb6192
Compare
|
@bcc32 You're absolutely right! I had pushed the quoted line, please help review again. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phase out the
spacemacs|dotspacemacs-backward-compatibility.The
Phase out the spacemacs|dotspacemacs-backward-compatibilitywas compiled into thehybrid-mode-autoloads.el, so we can NOT delete it directly, change it to warn.