Skip to content

[tools/shoestring]: Output node certificate as x509 v3 #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

ccHarvestasya
Copy link
Contributor

Problem

  • CA certificates are output as x509 v3, but node certificates are output as x509 v1.

Solution.

  • Output node certificate as x509 v3.

Copy link

codecov bot commented Jun 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (be149f3) to head (dce802a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1422      +/-   ##
==========================================
- Coverage   98.26%   98.24%   -0.03%     
==========================================
  Files         163      158       -5     
  Lines        6691     6557     -134     
  Branches      143      143              
==========================================
- Hits         6575     6442     -133     
+ Misses        116      115       -1     
Flag Coverage Δ
explorer-rest ?
tools-shoestring 96.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...oestring/shoestring/internal/CertificateFactory.py 100.00% <ø> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant