Skip to content

shoestring: add gettext fallback=True to avoid missing messages error #1472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

u2yasan
Copy link

@u2yasan u2yasan commented Jul 7, 2025

Fixes missing translation files by adding fallback=True to gettext.translation calls in both the main CLI and the wizard.

Copy link

codecov bot commented Jul 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.26%. Comparing base (c028861) to head (04293a8).
Report is 2 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1472      +/-   ##
==========================================
- Coverage   98.28%   98.26%   -0.02%     
==========================================
  Files         164      159       -5     
  Lines        6770     6636     -134     
  Branches      143      143              
==========================================
- Hits         6654     6521     -133     
+ Misses        116      115       -1     
Flag Coverage Δ
explorer-rest ?
tools-shoestring 97.03% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/shoestring/shoestring/__main__.py 97.61% <100.00%> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant