-
Notifications
You must be signed in to change notification settings - Fork 9
[bridge]: update network facades to support arbitrary mosaics #1479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bridge]: update network facades to support arbitrary mosaics #1479
Conversation
Jaguar0625
commented
Jul 8, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/bridge #1479 +/- ##
==================================================
- Coverage 98.37% 98.36% -0.02%
==================================================
Files 176 171 -5
Lines 7215 7092 -123
Branches 143 143
==================================================
- Hits 7098 6976 -122
+ Misses 117 116 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ea9afd0
to
477dad5
Compare
eef8ba6
to
35ed134
Compare
477dad5
to
8bf73f2
Compare
88a17e5
to
13becc3
Compare
8bf73f2
to
a287edc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏾
7cb9177
to
c7f7844
Compare
problem: inconsistent namings should be fixed solution: rename can_create_wrap_request_* * can(not)_create_wrap_request_* => can(not)_extract_wrap_request_* * transaction_meta_json => transaction_with_meta_json
13becc3
to
40f2169
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏾
problem: network facades primarily support currency mosaic operations solution: generalize to supporting arbitrary mosaics
60d2151
to
4c4ad12
Compare