Skip to content

[bridge]: update network facades to support arbitrary mosaics #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Jaguar0625
Copy link
Contributor

[bridge]: update network facades to support arbitrary mosaics

 problem: network facades primarily support currency mosaic operations
solution: generalize to supporting arbitrary mosaics


[bridge]: fix some naming issues in tests

 problem: inconsistent namings should be fixed
solution: rename can_create_wrap_request_*
          * can(not)_create_wrap_request_* => can(not)_extract_wrap_request_*
          * transaction_meta_json => transaction_with_meta_json

@Jaguar0625 Jaguar0625 requested a review from Wayonb July 8, 2025 19:47
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (c7f7844) to head (4c4ad12).
Report is 2 commits behind head on feature/bridge.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           feature/bridge    #1479      +/-   ##
==================================================
- Coverage           98.37%   98.36%   -0.02%     
==================================================
  Files                 176      171       -5     
  Lines                7215     7092     -123     
  Branches              143      143              
==================================================
- Hits                 7098     6976     -122     
+ Misses                117      116       -1     
Flag Coverage Δ
bridge 100.00% <100.00%> (ø)
explorer-rest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
bridge/bridge/nem/NemNetworkFacade.py 100.00% <100.00%> (ø)
bridge/bridge/nem/NemUtils.py 100.00% <100.00%> (ø)
bridge/bridge/symbol/SymbolNetworkFacade.py 100.00% <100.00%> (ø)
bridge/bridge/symbol/SymbolUtils.py 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jaguar0625 Jaguar0625 force-pushed the task/bridge/finish-wrap-database branch from ea9afd0 to 477dad5 Compare July 8, 2025 20:39
@Jaguar0625 Jaguar0625 force-pushed the task/bridge/network-facade-arbitrary-mosaic-processing branch from eef8ba6 to 35ed134 Compare July 8, 2025 20:40
@Jaguar0625 Jaguar0625 force-pushed the task/bridge/finish-wrap-database branch from 477dad5 to 8bf73f2 Compare July 9, 2025 12:43
@Jaguar0625 Jaguar0625 force-pushed the task/bridge/network-facade-arbitrary-mosaic-processing branch 2 times, most recently from 88a17e5 to 13becc3 Compare July 9, 2025 13:05
@Jaguar0625 Jaguar0625 force-pushed the task/bridge/finish-wrap-database branch from 8bf73f2 to a287edc Compare July 9, 2025 13:05
Copy link
Contributor

@Wayonb Wayonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

@Jaguar0625 Jaguar0625 requested a review from Wayonb July 21, 2025 22:15
@Jaguar0625 Jaguar0625 force-pushed the task/bridge/finish-wrap-database branch from 7cb9177 to c7f7844 Compare July 22, 2025 12:54
Base automatically changed from task/bridge/finish-wrap-database to feature/bridge July 22, 2025 13:09
 problem: inconsistent namings should be fixed
solution: rename can_create_wrap_request_*
          * can(not)_create_wrap_request_* => can(not)_extract_wrap_request_*
          * transaction_meta_json => transaction_with_meta_json
@Jaguar0625 Jaguar0625 force-pushed the task/bridge/network-facade-arbitrary-mosaic-processing branch from 13becc3 to 40f2169 Compare July 22, 2025 13:11
Copy link
Contributor

@Wayonb Wayonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

 problem: network facades primarily support currency mosaic operations
solution: generalize to supporting arbitrary mosaics
@Jaguar0625 Jaguar0625 force-pushed the task/bridge/network-facade-arbitrary-mosaic-processing branch from 60d2151 to 4c4ad12 Compare July 22, 2025 15:06
@Jaguar0625 Jaguar0625 merged commit 4c4ad12 into feature/bridge Jul 22, 2025
14 checks passed
@Jaguar0625 Jaguar0625 deleted the task/bridge/network-facade-arbitrary-mosaic-processing branch July 22, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants