Cleanup Docker volume for SIGTERM #368
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bauersimon
force-pushed
the
366-cleanup-docker-volume
branch
from
e0f3d7a
to
07a3460
Compare
Fixes #366 Not sure worth doing an actual test case cause it would be quite complex (i.e. starting a separate binary and then simulating SIGTERM, ensuring that the volume is then removed). Verified that it works.
bauersimon
force-pushed
the
366-cleanup-docker-volume
branch
from
07a3460
to
c3a20f0
Compare
bauersimon
requested review from
zimmski,
ruiAzevedo19 and
ahumenberger
and removed request for
zimmski
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.