This repository has been archived by the owner on Sep 16, 2021. It is now read-only.
agressively prefetch the menu as it needs to be completely loaded anyways #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dbu
commented
Dec 16, 2013
dbu
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | travis |
| Fixed tickets | partially #162 |
| License | MIT |
| Doc PR | symfony-cmf/symfony-cmf-docs#374 |
|
i guess we need to bump the dependency on the testing lib to 1.1? or use dev-master .. ? |
|
ok bumped it to 1.1 .. but now we have a new issue likely due to the recent CoreBundle merge: |
|
ugh, i merged symfony-cmf/core-bundle#110 today, @dantleech added configuration options. so it seems the defaults are not set. @dantleech could you have a look and do a follow up PR? |
|
pr here: symfony-cmf/core-bundle#112 |
|
@lsmith77 okay, i triggered a rebuild on travis, lets see. |
|
| @@ -32,7 +32,8 @@ public function getConfigTreeBuilder() | |||
| ->canBeEnabled() | |||
| ->children() | |||
| ->scalarNode('menu_basepath')->defaultValue('/cms/menu')->end() | |||
| ->scalarNode('content_basepath')->defaultValue('/cms/content')->end() | |||
| ->scalarNode('content_basepath')->defaultNull()->end() | |||
| ->scalarNode('prefetch')->defaultValue(10)->end() | |||
There was a problem hiding this comment.
TODO: update xml schema (wait for #167 to be merged)
|
alright, test is fixed hopefully. we do not test the actual prefetch activity however. |
| @@ -33,6 +33,7 @@ public function getConfigTreeBuilder() | |||
| ->children() | |||
| ->scalarNode('menu_basepath')->defaultValue('/cms/menu')->end() | |||
| ->scalarNode('content_basepath')->defaultValue('/cms/content')->end() | |||
| ->scalarNode('prefetch')->defaultValue(10)->end() | |||
There was a problem hiding this comment.
oh, was not aware that integerNode even exists. thanks.
dbu
added a commit
that referenced
this pull request
Jan 10, 2014
agressively prefetch the menu as it needs to be completely loaded anyways
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.