-
-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added StfalconTinymceBundle #26
Conversation
@javiereguiluz yes, of course. thanks dude! ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request does not pass validation.
@symfony-flex-server review please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request does not pass validation.
"Stfalcon\\Bundle\\TinymceBundle\\StfalconTinymceBundle": ["all"] | ||
}, | ||
"copy-from-recipe": { | ||
"etc/": "%ETC_DIR%/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This need to be updated.
"config/": "%CONFIG_DIR%/"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request does not pass validation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request does not pass validation.
Thank you @javiereguiluz. I asked the bundle to tag 2.2. Could you move the recipe from 2.1 to 2.2? After that I think you are done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request does not pass validation.
Tag |
@symfony-flex-server review please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request does not pass validation.
@symfony-flex-server review please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request does not pass validation.
@Nyholm this PR stalled. What should we do here? Update something? Close it? Thanks! |
We are blocked by stfalcon/TinymceBundle#225. And the maintainers do not seam to be eager to reply to me... @stfalcon or @metalslave, could you spend 3 minutes on stfalcon/TinymceBundle#232 ? |
I'm closing this because the upstream bundle is no longer active or it's not interested in this. Thank you and sorry for having wasted your time. |
About the bundle:
@stfalcon you are the creator of this bundle, so it'd be great if you could review this. The idea of the recipes is to provide no configuration or a minimal configuration. The default config options of the bundle should be the good ones for most of the users. So, I propose to include in the recipe config only the two options that you may need to change or at least control more closely.
Do you agree? Would you add more must-have config options? Would you remove these? Thanks!