Skip to content

[Icons] explain svg size #2670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Open

[Icons] explain svg size #2670

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/Icons/doc/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,21 @@ define the HTML attributes added to the ``<svg>`` element:
{{ ux_icon('user-profile', {height: '16px', width: '16px', 'aria-hidden': true}) }}
{# renders <svg height="16" width="16" aria-hidden="true"> ... </svg> #}

.. note::

Without size instructions, ``<svg>`` elements will be dynamically sized by the browser.
For icons, we therefore recommend to explicitly set the size. This can be done with a
CSS class or a height attribute in pixels, with variables of your CSS framework or using
``em`` to set the size in relation to the font size of the current element.

Note that it is enough to specify the height, the width will be adjusted accordingly:

.. code-block:: twig

{{ ux_icon('user-profile', {style: 'height: 1em;'}) }}

For a consistent look, you might want to set the size through a
:ref:`default attribute <icons_default_attributes>`.
Comment on lines +86 to +100
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. note::
Without size instructions, ``<svg>`` elements will be dynamically sized by the browser.
For icons, we therefore recommend to explicitly set the size. This can be done with a
CSS class or a height attribute in pixels, with variables of your CSS framework or using
``em`` to set the size in relation to the font size of the current element.
Note that it is enough to specify the height, the width will be adjusted accordingly:
.. code-block:: twig
{{ ux_icon('user-profile', {style: 'height: 1em;'}) }}
For a consistent look, you might want to set the size through a
:ref:`default attribute <icons_default_attributes>`.
Icon Sizes
~~~~~~~~
.. note::
``<svg>`` elements will be dynamically sized by the browser.
For icons, we therefore recommend to explicitly set the size.
To align icons naturally with surrounding text and inherit font sizing, use ``em``
units. This works well for buttons, links, or inline text. Defining the height alone
is sufficient—the width will scale proportionally:
.. code-block::twig
{# Twig function #}
{{ ux_icon('user-profile', {style: 'height: 1em;'}) }}
{# HTML syntax #}
<twig:ux:icon name="profile" style="height: 1em;" />
If your project uses a CSS framework like Tailwind or Bootstrap, prefer their
sizing utilities for consistency and theming:
.. code-block::twig
{# Twig function #}
{{ ux_icon('bi:chat', {class: 'size-4'}) }}
{# HTML syntax #}
<twig:ux:icon name="bi:chat" class="size-4" />
To keep your design consistent and easily adjustable, consider defining a :ref:default attribute <icons_default_attributes>. This allows you to control the size of all your icons from a single place.

wdyt?


Icon Sets
~~~~~~~~~
Expand Down Expand Up @@ -313,6 +328,8 @@ HTML Syntax

``symfony/ux-twig-component`` is required to use the HTML syntax.

.. _icons_default_attributes:

Default Attributes
~~~~~~~~~~~~~~~~~~

Expand Down