[Icons] improve DX when symfony/http-client is not installed
#2678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Feature
kbond
force-pushed
the
icons/no-http-client
branch
3 times, most recently
from
8bc80c3 to
2c18a5f
Compare
carsonbot
added
Status: Reviewed
smnandre
reviewed
Apr 7, 2025
|
|
||
| .. caution:: | ||
|
|
||
| The process to find icons to cache in your Twig templates is imperfect. It |
There was a problem hiding this comment.
Maybe advise Lock command here? It shows details (-vv) on wether the IconSet does not exist (99% of the false positive extracted from templates) or if there is a real problem with an icon.
There was a problem hiding this comment.
I added this caution admonition to the lock command section too.
- throw exception if http-client is not available - always enable iconify, iconify commands and on-demand registry - display "potential" missing icons to `ux:icons:warm-cache`
kbond
force-pushed
the
icons/no-http-client
branch
from
2c18a5f to
c14e89b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ux:icons:warm-cache(addresses [Icons] report issues in ux:icons:warm-cache #2668)Exception when rendering a template w/o http-client:
Exception when running ux:icon:* command w/o http-client:
Output of
ux:icons:warm -vwhen there are "potential" invalid icons:TODO