Skip to content

Add .editorconfig, enforce LF line-ending style #2691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2025
Merged

Add .editorconfig, enforce LF line-ending style #2691

merged 1 commit into from
Apr 13, 2025

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Apr 11, 2025

Q A
Bug fix? no
New feature? no
Docs? no
Issues Fix #...
License MIT

Following #2687

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Apr 11, 2025
@Kocal Kocal requested review from kbond and smnandre April 11, 2025 09:00
@github-actions GitHub Actions
Copy link

📊 Packages dist files size difference

Thanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
Please review the changes and make sure they are expected.

FileBefore (Size / Gzip)After (Size / Gzip)
Autocomplete
controller.js 16.71 kB / 3.97 kB 16.68 kB0% / 3.96 kB0%

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Apr 11, 2025
kbond
kbond reviewed Apr 11, 2025
View reviewed changes
.editorconfig
insert_final_newline = true
trim_trailing_whitespace = true

[*.{php,html,twig}]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[*.{php,html,twig}]
[*.{php,html,twig,yml,yaml}]

smnandre
smnandre approved these changes Apr 11, 2025
View reviewed changes
Copy link
Member

@smnandre smnandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Kocal Kocal merged commit 4550368 into symfony:2.x Apr 13, 2025
78 of 80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbond kbond kbond approved these changes

@smnandre smnandre smnandre approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kocal @kbond @smnandre @carsonbot