Throw E_USER_NOTICE instead of E_USER_ERROR #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an image can not be loaded, a E_USER_ERROR is thrown. But Symphony's 404 errors, for example, trigger E_USER_NOTICE exceptions. So the latter should be enough here as well. This will allow to run big systems with suppressed notices, thus preventing the log file from being polluted with image errors (mainly caused by robots anyway). Fixes symphonycms#166
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an image can not be loaded, a E_USER_ERROR is thrown. But Symphony's 404 errors, for example, trigger E_USER_NOTICE exceptions. So the latter should be enough here as well.
This will allow to run big systems with suppressed notices, thus preventing the log file from being polluted with image errors (mainly caused by robots anyway).
Fixes #166