Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add fixtures for empty bind section case #43

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add fixtures for empty bind section case #43

wants to merge 1 commit into from

Conversation

COil
Copy link

@COil COil commented Dec 6, 2024

See #42

@COil COil changed the title feat: add fixture for empty bind section case feat: add fixtures for empty bind section case Dec 7, 2024
@COil
Copy link
Author

COil commented Dec 7, 2024 •
edited
Loading

Tests failed as expected (https://github.com/symplify/config-transformer/actions/runs/12204864897/job/34060006146?pr=43):

1) Symplify\ConfigTransformer\Tests\Converter\ConfigFormatConverter\YamlToPhp\YamlToPhpTest::testNormal 
with data set #7 (Symfony\Component\Finder\SplFileInfo Object (...))
TypeError: Symplify\PhpConfigPrinter\NodeFactory\Service\AutoBindNodeFactory::createBindMethodCall(): 
Argument #2 ($bindValues) must be of type array, null given, 
called in /home/runner/work/config-transformer/config-transformer/vendor/symplify/php-config-printer/src/NodeFactory/Service/AutoBindNodeFactory.php on line 44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@COil