SfTabView HeaderItemSpacing property#284
SfTabView HeaderItemSpacing property#284aleksandervalle wants to merge 1 commit intosyncfusion:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
Introduces a new HeaderItemSpacing property to SfTabView that allows customization of spacing between header items in the tab bar. The property replaces a previously hardcoded value of 36 pixels while maintaining backward compatibility by using 36 as the default value.
Key Changes:
- Added
HeaderItemSpacingproperty toSfTabViewandSfTabBarwith a default value of 36 - Replaced hardcoded
_defaultTextPaddingconstant with the configurableHeaderItemSpacingproperty throughout tab item width calculations - Implemented property change handlers to propagate spacing updates from
SfTabViewtoSfTabBar
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| maui/src/TabView/Control/SfTabView.cs | Adds public HeaderItemSpacing property with bindable property definition, documentation, and propagation logic to the tab bar |
| maui/src/TabView/Control/SfTabBar.cs | Adds internal HeaderItemSpacing property and updates all width calculation methods to use the property instead of the hardcoded constant |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
If this looks good, I can make a PR for the syncfusion-content/maui-toolkit-docs too (to document this new property). |
aleksandervalle
force-pushed
the
main
branch
from
a8854c3 to
0173097
Compare
Introduce new property to enable customization of spacing between tab header items. Previously hardcoded to 36.
aleksandervalle
force-pushed
the
main
branch
from
0173097 to
512024b
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hi @aleksandervalle, |
Root Cause of the Issue
We need to customize the spacing between header items in the TabView. This spacing is currently hardcoded to 36 (see https://github.com/syncfusion/maui-toolkit/blob/main/maui/src/TabView/Control/SfTabBar.cs#L33).
Description of Change
Introduces a new HeaderItemSpacing property on SfTabView, piped down to SfTabBar.
Preserves current value 36 as default value.
Screenshots