Skip to content

Add support for debug log level#1

Open
soote1 wants to merge 1 commit intosyngenta-digital:masterfrom
soote1:master
Open

Add support for debug log level#1
soote1 wants to merge 1 commit intosyngenta-digital:masterfrom
soote1:master

Conversation

@soote1
Copy link

@soote1 soote1 commented Feb 3, 2023

We (global-devops team) would like to enhance our logging strategy in all our lambda functions. To achieve that, we would like to add logging instructions with different logging levels and control them via an environment variable. We noticed that the package supports the latter requirement. However, with regard to logging levels, we realized that it doesn't support DEBUG. While working on the required changes to provide such feature, we realized that the logic to check if the data should be logged in CommonLogger.log() was incorrect. Basically, the **kwargs were not being propagated to CommonLogger.__should_log() method. Thus, CommonLogger.__get_log_level() method was returning an incorrect value.

That said, this PR provides a set of changes to:

  • Add support for DEBUG log level
  • Fix an issue while checking if the CommonLogger should log the given data.

Signed-off-by: Isaias Ramirez Lopez [email protected]

Signed-off-by: Isaias Ramirez Lopez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants