Skip to content

changing logic for colors generate in reports.#28

Merged
nitesh-syngenta merged 2 commits intosyngenta:mainfrom
AnshulMishraSyn:CWTRC-1125-colors-issue
Jan 7, 2026
Merged

changing logic for colors generate in reports.#28
nitesh-syngenta merged 2 commits intosyngenta:mainfrom
AnshulMishraSyn:CWTRC-1125-colors-issue

Conversation

@AnshulMishraSyn
Copy link
Collaborator

changing logic for colors generate in reports. similar to the trials

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the color generation logic for reports to align with trial visualizations. The main change introduces dynamic color lookup from trial data instead of relying solely on algorithmic color selection based on rates and averages.

Key Changes:

  • Modified color utility functions (getColorForSeeds, getColorForBiologicals, getColorForFertilisers) to first check trial data for existing colors before falling back to algorithmic generation
  • Added HSL color conversion helpers to support gradient-based color generation for fertilizers
  • Threaded trialPlots parameter through map rendering functions to enable color lookup

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 10 comments.

File Description
src/utils/colorUtils.ts Core changes to color generation logic: added trial data lookup for seeds, biologicals, and fertilizers; implemented HSL-based gradient generation for fertilizer colors
src/methods/map/addTrialPlotsToMap.ts Passes trialPlots parameter through to color utility functions; includes formatting improvements
src/components/map/addTrialPlotsToMap.ts Formatting improvements only (no functional changes to support new color logic)
package-lock.json Version bump from 0.0.4 to 0.0.6 with dependency updates

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nitesh-syngenta nitesh-syngenta merged commit 7b5bf29 into syngenta:main Jan 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants