changing logic for colors generate in reports.#28
Merged
nitesh-syngenta merged 2 commits intosyngenta:mainfrom Jan 7, 2026
Merged
changing logic for colors generate in reports.#28nitesh-syngenta merged 2 commits intosyngenta:mainfrom
nitesh-syngenta merged 2 commits intosyngenta:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates the color generation logic for reports to align with trial visualizations. The main change introduces dynamic color lookup from trial data instead of relying solely on algorithmic color selection based on rates and averages.
Key Changes:
- Modified color utility functions (
getColorForSeeds,getColorForBiologicals,getColorForFertilisers) to first check trial data for existing colors before falling back to algorithmic generation - Added HSL color conversion helpers to support gradient-based color generation for fertilizers
- Threaded
trialPlotsparameter through map rendering functions to enable color lookup
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
| src/utils/colorUtils.ts | Core changes to color generation logic: added trial data lookup for seeds, biologicals, and fertilizers; implemented HSL-based gradient generation for fertilizer colors |
| src/methods/map/addTrialPlotsToMap.ts | Passes trialPlots parameter through to color utility functions; includes formatting improvements |
| src/components/map/addTrialPlotsToMap.ts | Formatting improvements only (no functional changes to support new color logic) |
| package-lock.json | Version bump from 0.0.4 to 0.0.6 with dependency updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nitesh-syngenta
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changing logic for colors generate in reports. similar to the trials