docs(fix): install hast types in development only#25
Closed
felixranesberger wants to merge 1 commit intosyntax-tree:mainfrom
Closed
docs(fix): install hast types in development only#25felixranesberger wants to merge 1 commit intosyntax-tree:mainfrom
felixranesberger wants to merge 1 commit intosyntax-tree:mainfrom
Conversation
Signed-off-by: Felix Ranesberger <[email protected]>
This comment has been minimized.
This comment has been minimized.
Member
ChristianMurphy
left a comment
ChristianMurphy
left a comment
There was a problem hiding this comment.
It depends on the use case.
As a library dependency is the only correct way, it needs to go downstream.
As an application it could go either way.
Member
|
There are use cases where types (or anything really) may be a dev dependency. Whatever it is, depends on the project. For most use cases this is false. IMO we leave the instructions as-is. |
Member
|
It depends! There are also cases where other flags are useful. This section isn’t always 100% right for everyone and that’s fine. For me, it signals that it’s on the npm registry, and what the exact (scoped) package name is! Thanks for thinking of this! |
This comment has been minimized.
This comment has been minimized.
github-actions
bot
added
👎 phase/no
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I just read your documentation and think that installing the @types for hast should probably only be done for development only.