Fix pre-push.hook validation bug #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We utilize ./scripts/pre-push.hook to do the checking when trying to do `git push`. One of the stages is to check a speicific commit hash number for validation of the repository. It tries to get the hash number of commit 3ed1723, using a filter to get the value of `commit` whose git log message matches the pattern specified in line 15 of `/scripts/pre-push.hook`. However when merging the commit into the master branch, it generated a new commit which is 390ade9, so the value of `commit` in line 15 of `/scripts/pre-push.hook` will be incorrect. That's why we modify a small part of the command in line 15 from `-n 1` to `--skip 1`, so we can neglect the merging commit and get the actual commit hash number we want. Fix sysprog21#151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We utilize ./scripts/pre-push.hook to do the checking when trying to do
git push. One of the stages is to check a speicific commit hash number for validation of the repository.It tries to get the hash number of commit
3ed17237af5b1ead6c394df5099bc2bc1f8392df, using a filter to get the value ofcommitwhose git log message matches the pattern specified in line 15 of/scripts/pre-push.hook.However when merging the commit into the master branch, it generated a new commit which is
390ade9eca44b432acb758084e7122cc2c46e485, so the value ofcommitin line 15 of/scripts/pre-push.hookwill be incorrect.That's why we modify a small part of the command in line 15 from
-n 1to--skip 1, so we can neglect the merging commit and get the actual commit hash number we want.Fixed Issue
Fixed #151