fix rmmod panic in bh_threaded #319
Closed
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
request_threaded_irq with device_id, so free_irq should "release" it, otherwise rmmod would panic.
fixed in fails
jserv
requested changes
May 7, 2025
There was a problem hiding this comment.
Check https://cbea.ms/git-commit/ and refine the commits. Also, consider to squash for review.
|
Thanks for the advice, I will close this, fix the git log and start new one later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
request_threaded_irq with device_id, so free_irq should "release" it, otherwise rmmod would panic.
Summary by Bito
This pull request fixes a critical bug in bh_threaded.c by ensuring the free_irq function properly releases IRQs for buttons, preventing system panic during module removal and enhancing overall system stability. This enhancement is vital for maintaining overall system stability.Unit tests added: False
Estimated effort to review (1-5, lower is better): 2