Revise the dependent modules #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix the wrong mod name. is videobuf2-vmalloc, not videobuf2_vmalloc . same as videobuf2-v4l2 https://github.com/torvalds/linux/blob/master/drivers/media/common/videobuf2/videobuf2-vmalloc.c https://github.com/torvalds/linux/blob/master/drivers/media/common/videobuf2/videobuf2-v4l2.c
jserv
requested changes
May 24, 2023
There was a problem hiding this comment.
Read https://cbea.ms/git-commit/ carefully and refine the git commit message.
|
You have to ensure that recent kernel versions come with the same module names. If not, you shall specify the versioning information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the wrong mod name
In section
$ sudo modprobe -a videobuf2_vmalloc videobuf2_v4l2, mod'sname in kernel 5.19.0-42-generic, should use
-to connect, not_.In root/drivers/media/Makefile line 32:
obj-y += common/ platform/ pci/ usb/ mmc/ firewire/ spi/ test-drivers/and root/drivers/media/common/videobuf2/Makefile line 16-17:
we can know .ko file name will be videobuf2-v4l2.ko rather than videobuf2_v4l2.ko.
refer by:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/media/Makefile?h=v6.3.3
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/media/common/videobuf2/Makefile?h=v6.3.3