Set DEFAULT_HOSTNAME in os-release when specified (fixes #2673)
#2963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behrmann
reviewed
Aug 21, 2024
septatrix
force-pushed
the
enhance/os-release-hostname
branch
from
8151c7b
to
1302d3c
Compare
DaanDeMeyer
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user specifies a hostname in the mkosi config they intend this to be the hostname which the system should have by default. Setting this in the os-release file ensures that this will also be applied up after a DHCP lease expires and the previous transient hostname was lost (in case no hostname exists under /etc as is the case for a /usr-only system).