Replace PACKAGE_GLOBS with PackageManager.package_globs() #3909
+36
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
split-out of #3908. |
yuwata
force-pushed
the
several-cleanups
branch
3 times, most recently
from
092b0ba to
a914133
Compare
Also, move the core part of install_package_directories() into PackageManager.install_package_directories() to allow to override it.
yuwata
force-pushed
the
several-cleanups
branch
from
a914133 to
117e230
Compare
yuwata
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, move the core part of install_package_directories() into PackageManager.install_package_directories() to allow to override it.