Skip to content

Conversation

DaanDeMeyer
Copy link
Contributor

No description provided.

Comment on lines +13 to +14
result = parents_below(path, below)
assert result == [Path("/a/b/c/d"), Path("/a/b/c")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the result is a bit superfluous and makes it easier to read, since it's a repeated line that doesn't do anything

Suggested change
result = parents_below(path, below)
assert result == [Path("/a/b/c/d"), Path("/a/b/c")]
assert parents_below(path, below) == [Path("/a/b/c/d"), Path("/a/b/c")]

The tests that raise break this pattern.

parents_below(path, below)


def test_parents_below_root() -> None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check should be further up, since it's basically the same as _basic and doesn't really fit the pattern after the raising tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants