Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manager struct cleanups #124

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Manager struct cleanups #124

merged 2 commits into from
Oct 7, 2024

Conversation

cgzones
Copy link
Contributor

@cgzones cgzones commented Oct 6, 2024

No description provided.

@ssahani
Copy link
Collaborator

ssahani commented Oct 7, 2024

All the drops can be squashed into one commit.

The member current_cursor is used only locally in a single function, and
always assigned before usage.
Drop Manager member socklen

The member socklen is used only locally in a single function, and always
assigned before usage.

The timeout member is never read from.
This also makes the call of sd_journal_reliable_fd(3) unnecessary.
@ssahani ssahani merged commit 8ec7067 into systemd:main Oct 7, 2024
1 check passed
@ssahani
Copy link
Collaborator

ssahani commented Oct 7, 2024

Thank you

@cgzones cgzones deleted the manager_members branch October 7, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants