shadcn React 19 #1243
shadcn React 19 #1243
Conversation
|
This should merge after #1233 |
they don't include ref as prop yet
| ); | ||
| }, | ||
| ); | ||
| Button.displayName = "Button"; |
There was a problem hiding this comment.
Hi, I'm curious as to why we don't need displayName anymore. (tbh I don't know the purpose of it in the first place) do you have any resources to share about this?
There was a problem hiding this comment.
From what I understand it's cause the component function inside the forwardRef previously was an anonymous function. you could have done forwardRef(function Button(...)) and have the displayName inferred before.
There was a problem hiding this comment.
Yes. Same goes for memo().
There was a problem hiding this comment.
(tbh I don't know the purpose of it in the first place)
https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/display-name.md
DisplayName allows you to name your component. This name is used by React in debugging messages.
Update shadcn components to use React 19 (removed forwardRefs) and clean up.