Skip to content

Conversation

carloschida
Copy link
Contributor

As per the tailwind v4.1 docs, the custom variant dark should be

@custom-variant dark (&:where(.dark, .dark *));

So that, along with the next-themes provider the classes get applied.

This may very well be a stylistic choice but I found it troubling that main didn't not change background or inherited it from the body.

@carloschida
Copy link
Contributor Author

I noticed that this is a consequence of a mismatch in the custom variant selector between shadcn and TW.

I opened it for discussion over there: shadcn-ui/ui#8481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant