W-17092332: Fix for updating functions without is_public set #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at never had is public set
| current_is_public = False | ||
| if hasattr(endpoint_info, "is_public"): | ||
| current_is_public = endpoint_info["is_public"] | ||
| is_public = self._check_and_set_is_public(is_public, current_is_public) |
There was a problem hiding this comment.
Looks great! Another option with getattr:
is_public = self._check_and_set_is_public(is_public, getattr(endpoint_info, "is_public", False))
There was a problem hiding this comment.
I like this. Much neater.
jakeichikawasalesforce
approved these changes
Oct 31, 2024
dleskosky
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update_endpoint_info, and deploy with override set to True were both broken when trying to update a function that had been deployed before is_public existed.
The update code searched for the is_public attribute, and failed when it did not exist. To fix this, when updating a function we first check that is_public exist, and if it does not we default it False if no specific value is set in deploy or update.