Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import Dan's PR for alias feature #20

Merged
merged 4 commits into from
Aug 23, 2023
Merged

import Dan's PR for alias feature #20

merged 4 commits into from
Aug 23, 2023

Conversation

joewagner
Copy link
Contributor

This imports the PR located in the single package repo here: https://github.com/tablelandnetwork/js-tableland-cli/pull/404/files

@joewagner
Copy link
Contributor Author

@dtbuchholz I had to work through some conflicts, but this should be good to go. The only thing I changed in regard to your PR in the singular repo was moving a conditional check into the helper. i.e. this line
If you're ok with that, and this all still looks right can you give a 👍 for this?

@dtbuchholz dtbuchholz marked this pull request as ready for review August 23, 2023 19:22
Copy link
Contributor

@dtbuchholz dtbuchholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joewagner your change makes sense, and lgtm!

@joewagner joewagner merged commit 9cbc584 into main Aug 23, 2023
4 checks passed
@joewagner joewagner deleted the cli-alias-pr branch August 23, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants