refactor: add utility to err on unreachable branches #991
+371
−349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice to add some usage examples for the new utilities |
verytactical
force-pushed
the
tact-915
branch
from
4ecf064
to
027ac91
Compare
novusnota
reviewed
Oct 30, 2024
|
Perhaps let's try applying it to the map key/value pair types once #993 is merged |
verytactical
force-pushed
the
tact-915
branch
from
027ac91
to
d6715e0
Compare
anton-trunov
requested changes
Nov 6, 2024
| return this.interpretStaticCall(ast); | ||
| } | ||
| } | ||
| public interpretExpression = (ast: AstExpression): Value => |
There was a problem hiding this comment.
I think this change is not strictly necessary, since a missing case in this switch should be caught by ESLint.
| case "int": | ||
| return ", int vl"; | ||
| } | ||
| return match(key) |
There was a problem hiding this comment.
I would say this change is not strictly necessary, ESLint would catch it.
|
CI is not all green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #915.
Checklist