Skip to content

Conversation

@Mingun
Copy link
Collaborator

@Mingun Mingun commented Oct 25, 2025

Serde 1.0.221 deprecated serde_if_integer128 macro, which leads to warnings when compile quick-xml. That macro does nothing since serde 1.0.187, and since 1.0.180 serde requires compiler >=1.26 which stabilizes 128-bit integers.

So it seems that it is enough to require serde >=1.0.180

@Mingun Mingun added the serde Issues related to mapping from Rust types to XML label Oct 25, 2025
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 58.08%. Comparing base (38b44d4) to head (d1acdb5).
⚠️ Report is 78 commits behind head on master.

Files with missing lines Patch % Lines
src/de/mod.rs 0.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #908      +/-   ##
==========================================
+ Coverage   55.52%   58.08%   +2.55%     
==========================================
  Files          42       42              
  Lines       15511    15513       +2     
==========================================
+ Hits         8613     9011     +398     
+ Misses       6898     6502     -396     
Flag Coverage Δ
unittests 58.08% <0.00%> (+2.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Mingun
Copy link
Collaborator Author

Mingun commented Oct 25, 2025

I do not like to bump dependencies in patch releases so hold this until minor release. I did not look at #904 yet, so if it go into patch, I'll merge it first.

@Mingun Mingun force-pushed the remove-serde_if_integer128 branch from cb34329 to 63330b8 Compare November 11, 2025 19:23
@Mingun Mingun force-pushed the remove-serde_if_integer128 branch from 63330b8 to d1acdb5 Compare November 11, 2025 19:45
@Mingun Mingun merged commit 3b7e6db into tafia:master Nov 11, 2025
7 checks passed
@Mingun Mingun deleted the remove-serde_if_integer128 branch November 11, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

serde Issues related to mapping from Rust types to XML

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants